Skip to content

Readd root/admin user detection #6593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
me4502 merged 11 commits into from
Oct 2, 2021
Merged

Readd root/admin user detection #6593

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
597a378
Readd root/admin user detection
NoahvdAa Sep 11, 2021
f601aa1
Use original test for Windows, use UID for unix and add co-author
NoahvdAa Sep 12, 2021
574c6f4
Move logging and remove unnecessary reader
NoahvdAa Sep 12, 2021
f3c1c7d
try with resources
NoahvdAa Sep 12, 2021
eeae49e
Use Windows security identifiers + reduce size of Unix check
NoahvdAa Sep 12, 2021
49e124d
Remove extra newline at the bottom of the message
NoahvdAa Sep 13, 2021
f039623
Change wording
NoahvdAa Sep 13, 2021
eeb9df1
Address comments
NoahvdAa Sep 20, 2021
c7e0bb7
Link to Maddy's article
NoahvdAa Sep 20, 2021
65ed556
Use warning log level
NoahvdAa Sep 20, 2021
8f9d43f
Rebase patches
me4502 Oct 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change wording
  • Loading branch information
@NoahvdAa @me4502
NoahvdAa authored and me4502 committed Oct 2, 2021
commit f039623a63d07ded0ad4a547dc63c26f0a1e39a9
6 changes: 3 additions & 3 deletions patches/server/0806-Add-root-admin-user-detection.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ index 0000000000000000000000000000000000000000..5ba45a071a5b7e9f2ef9f2dea7e07d74
+ }
+}
diff --git a/src/main/java/net/minecraft/server/dedicated/DedicatedServer.java b/src/main/java/net/minecraft/server/dedicated/DedicatedServer.java
index 1bf19965d12514dee34545235bfbadc0b74ddc8b..ed5a2edc8b07ddf9e0c4400430c9a17b5fb28216 100644
index 1bf19965d12514dee34545235bfbadc0b74ddc8b..4b201132deb68e5990e8318419611e40530379cc 100644
--- a/src/main/java/net/minecraft/server/dedicated/DedicatedServer.java
+++ b/src/main/java/net/minecraft/server/dedicated/DedicatedServer.java
@@ -190,6 +190,16 @@ public class DedicatedServer extends MinecraftServer implements ServerInterface
Expand All @@ -56,9 +56,9 @@ index 1bf19965d12514dee34545235bfbadc0b74ddc8b..ed5a2edc8b07ddf9e0c4400430c9a17b
+ // Paper start - detect running as root
+ if (io.papermc.paper.util.ServerEnvironment.userIsRootOrAdmin()) {
+ DedicatedServer.LOGGER.error("****************************");
+ DedicatedServer.LOGGER.error("YOU ARE RUNNING AS AN ADMINISTRATIVE OR ROOT USER. THIS IS NOT ADVISED.");
+ DedicatedServer.LOGGER.error("YOU ARE RUNNING THIS SERVER AS AN ADMINISTRATIVE OR ROOT USER. THIS IS NOT ADVISED.");
+ DedicatedServer.LOGGER.error("YOU ARE OPENING YOURSELF UP TO POTENTIAL RISKS WHEN DOING THIS.");
+ DedicatedServer.LOGGER.error("MALWARE, BAD PLUGINS, AND ATTACKERS WILL HAVE COMPLETE ACCESS AND CONTROL OF YOUR MACHINE.");
+ DedicatedServer.LOGGER.error("MALWARE AND MALICIOUS PLUGINS WILL HAVE COMPLETE ACCESS AND CONTROL OF YOUR MACHINE.");
+ DedicatedServer.LOGGER.error("****************************");
+ }
+ // Paper end
Expand Down