Entity Rewrite - Settings get reset

[linsaftw]

When entity rewrite is disabled from waterfall.yml file, settings get reset each time you switch servers.

This only happens since 24b7e51 upstream update.

[linsaftw]

// Something deeper is going wrong here, but, as it stands, this project is EOL, so, we'll just shove this through.
if (user.getSettings() != null)
{
    ch.write( user.getSettings() );
}

I just forced this piece of code to always write settings and it fixed the issue.

[Janmm14]

I feel like if you would test his with bungee, this kind of bug would also get fixed in bungee (if bungee has it what it really sounds like here) if you open issue there.

[electronicboy]

disabling entity metadata rewriting is not a thing on bungee

[Janmm14]

uh ok i didnt check code in detail here.

edit: uh but 1.20 client doesnt really do entity rewriting on bungee as well?

[electronicboy]

Looks like I got the check backwards, this should be mitigated