Skip to content

Bungee legacy hover fix #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OOP-778 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bungee legacy hover fix #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca45788
Add via-facet to bungee
OOP-778 Nov 16, 2022
c398c85
Fix legacy hover
OOP-778 Nov 16, 2022
3a3ef12
Revert "Add via-facet to bungee"
OOP-778 Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions platform-bungeecord/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ dependencies {
api("net.kyori:adventure-text-serializer-gson:${rootProject.adventure}") {
exclude group: "com.google.code.gson"
}
implementation("net.kyori:adventure-text-serializer-gson-legacy-impl:${rootProject.adventure}") {
exclude group: "com.google.code.gson"
}
implementation project(":adventure-platform-viaversion")
implementation project(":adventure-platform-facet")
api project(":adventure-text-serializer-bungeecord")
compileOnly 'net.md-5:bungeecord-api:1.16-R0.4'
Expand Down
3 changes: 2 additions & 1 deletion platform-bungeecord/src/main/java/net/kyori/adventure/platform/bungeecord/BungeeFacet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import net.kyori.adventure.text.flattener.ComponentFlattener;
import net.kyori.adventure.text.serializer.bungeecord.BungeeComponentSerializer;
import net.kyori.adventure.text.serializer.gson.GsonComponentSerializer;
import net.kyori.adventure.text.serializer.gson.legacyimpl.NBTLegacyHoverEventSerializer;
import net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer;
import net.kyori.adventure.util.TriState;
import net.md_5.bungee.api.ChatMessageType;
Expand Down Expand Up @@ -69,7 +70,7 @@ class BungeeFacet<V extends CommandSender> extends FacetBase<V> {
.build()
);
static final BungeeComponentSerializer LEGACY = BungeeComponentSerializer.of(
GsonComponentSerializer.builder().downsampleColors().emitLegacyHoverEvent().build(),
GsonComponentSerializer.builder().downsampleColors().legacyHoverEventSerializer(NBTLegacyHoverEventSerializer.get()).emitLegacyHoverEvent().build(),
LegacyComponentSerializer.builder().flattener(FLATTENER).build()
);

Expand Down