Skip to content

NBT Component Serializer #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Codestech1 wants to merge 89 commits into
base: main/4
Choose a base branch
from
Open

NBT Component Serializer #1084

Changes from 1 commit
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
29c997a
feat: basic component serializing to nbt (without styling)
Codestech1 Jun 8, 2024
34a381a
feat: serialize component children and types
Codestech1 Jun 8, 2024
5bb4c5a
misc: i'm too lazy to name this commit, but it fixes and adds a lot o…
Codestech1 Jun 9, 2024
97809cf
chore: remove useless gson serializer
Codestech1 Jun 9, 2024
1c750c3
chore: add support for legacy item tags
Codestech1 Jun 9, 2024
92ea881
feat: component deserialization
Codestech1 Jun 9, 2024
9858a9f
fix: translatable component arguments aren't deserializing
Codestech1 Jun 9, 2024
4c7b00c
fix: legacy hover events aren't serialized properly
Codestech1 Jun 12, 2024
0a52c01
fix: serializing show entity as a legacy hover event throws an except…
Codestech1 Jun 12, 2024
a020c0a
misc: split the style serialization and deserialization to other class
Codestech1 Jun 13, 2024
a39a101
feat: add an emit rgb flag
Codestech1 Jun 13, 2024
8e74088
feat: add a builder for the nbt component serializer
Codestech1 Jun 13, 2024
f96ca38
chore: add a non-null requirement to NBTComponentSerializerImpl.Build…
Codestech1 Jun 13, 2024
bba80fb
feat: nbt component providers
Codestech1 Jun 13, 2024
0ec4d53
chore: add remaining serializer options to builder
Codestech1 Jun 15, 2024
e8b5efd
chore: cleanup
Codestech1 Jun 15, 2024
f8427a0
chore: add javadocs to and simplify NBTSerializerOptions and add lice…
Codestech1 Jun 15, 2024
8c43bac
chore: add javadocs for public classes
Codestech1 Jun 15, 2024
2f4c78c
chore: add tests
Codestech1 Jun 15, 2024
2021707
fix: hover events are not serialized properly, feat: add a test for h…
Codestech1 Jun 15, 2024
9021233
feat: add a test for click event
Codestech1 Jun 15, 2024
c7f406a
chore: resolve requested changes
Codestech1 Jun 19, 2024
cc298cb
feat: add a possibility to (de)-serialize a style without a component
Codestech1 Jun 19, 2024
8996ab0
chore: simplify serializing text colors with TextColor#toString
Codestech1 Jun 21, 2024
43c34aa
Merge branch 'KyoriPowered:main/4' into feat/nbt-text-serializer
Codestech1 May 9, 2025
da4737c
Merge branch 'KyoriPowered:main/4' into feat/nbt-text-serializer
Codestech1 Jun 20, 2025
c5e3525
feat: shadow color serializing
Codestech1 Jun 20, 2025
6e77a33
chore: update all `@since` tags to use version 4.24.0
Codestech1 Jun 20, 2025
95bd146
chore: update ClickEventSerializer to support the latest format
Codestech1 Jun 21, 2025
847b477
chore: create ShowItemSerializer for future use in StyleSerializer to…
Codestech1 Jun 21, 2025
8cc7c47
misc: fix double colon in JSON ShowItemSerializer
Codestech1 Jun 21, 2025
5591b42
chore: update ShowEntitySerializer to support the latest format
Codestech1 Jun 21, 2025
f955ef6
chore: update HoverEventSerializer to support the latest format
Codestech1 Jun 21, 2025
473e199
chore: add missing options to the NBTSerializerOptions
Codestech1 Jun 21, 2025
7d90b2f
chore: apply new serializing system of click events and hover events …
Codestech1 Jun 21, 2025
1500a14
chore: update StyleSerializer fields to support the latest format
Codestech1 Jun 21, 2025
5214303
chore: serialize and deserialize text decorations in loops
Codestech1 Jun 22, 2025
bf2092f
chore: ensure order of serializing and use ComponentTreeConstants in …
Codestech1 Jun 22, 2025
b2e6cd1
chore: do not serialize or deserialize "type" fields of components as…
Codestech1 Jun 22, 2025
2c10acd
chore: remove serialize/deserialize data sources TODO
Codestech1 Jun 22, 2025
7dc38e1
feat: add an option for emitting default nbt component interpret value
Codestech1 Jun 22, 2025
69e2a3f
chore: remove redundant cast in NBTSerializerUtils#getRequiredTag
Codestech1 Jun 22, 2025
a45a90c
chore: fix spacing in NBTSerializerUtils
Codestech1 Jun 22, 2025
7f7ccd5
chore: vanilla-like component children serializing
Codestech1 Jun 22, 2025
3cb553e
chore: vanilla-like translatable component arguments serializing
Codestech1 Jun 25, 2025
a85d088
chore: add missing license headers and update to 2025
Codestech1 Jun 25, 2025
1a948f2
chore: use TextDecoration#values for style decoration serialization (…
Codestech1 Jun 25, 2025
ad8d730
chore: use option schema for NBT serializer options instead
Codestech1 Jun 26, 2025
619a62a
feat: deserializing components from list binary tags
Codestech1 Jun 26, 2025
923905c
feat: deserialize and serialize legacy additional data of show item h…
Codestech1 Jun 26, 2025
0a354ce
chore: make the code consistent
Codestech1 Jun 28, 2025
15c63b6
feat: initial versioned option state with options for 23w40a
Codestech1 Jun 28, 2025
cd4a440
feat: support plain string show-item hover events in deserialization
Codestech1 Jun 28, 2025
6674ca9
feat: add 24w09a version to the versioned option state
Codestech1 Jun 28, 2025
3eb33f2
feat: add 24w44a version to the versioned option state
Codestech1 Jun 28, 2025
7d7b6b4
feat: add 25w02a version to the versioned option state
Codestech1 Jun 28, 2025
4a36ed3
chore: remove unneeded options
Codestech1 Jun 28, 2025
f6b30be
chore: replace ClickEventSerializer#deserializeCamel and ClickEventSe…
Codestech1 Jun 28, 2025
67e5711
chore: add TODO messages about show_text field names in HoverEventSer…
Codestech1 Jun 28, 2025
310d841
chore: review whether the serialization matches Minecraft 23w40a and …
Codestech1 Jun 28, 2025
8b0c247
chore: remove all previous tests
Codestech1 Jun 28, 2025
fee8bd0
feat: text component serialization test
Codestech1 Jun 28, 2025
bac65e1
chore: use ComponentTreeConstants instead for field names in TextComp…
Codestech1 Jun 28, 2025
0ab8662
feat: translatable component serialization test
Codestech1 Jun 28, 2025
514f23f
chore: make TextComponentTest package-private
Codestech1 Jun 28, 2025
bf1d2ab
feat: keybind component serialization test
Codestech1 Jun 28, 2025
ab6ae46
feat: score component serialization test
Codestech1 Jun 28, 2025
0b1d3ad
feat: selector component serialization test
Codestech1 Jun 28, 2025
dd6fcd1
feat: block NBT component serialization test
Codestech1 Jun 29, 2025
44c7953
feat: entity NBT component serialization test
Codestech1 Jun 29, 2025
904748a
feat: storage NBT component serialization test
Codestech1 Jun 29, 2025
0d2d83c
feat: component style serialization test, chore: use jetbrains not-nu…
Codestech1 Jun 29, 2025
bcafca4
feat: add a test for deserializing component from lists, fix: deseria…
Codestech1 Jun 29, 2025
7a6d5ce
feat: show entity serialization test
Codestech1 Jun 29, 2025
5e22119
feat: show item serialization test
Codestech1 Jun 30, 2025
fac131f
chore: cleanup tests
Codestech1 Jun 30, 2025
f61a594
feat: legacy hover event deserializing
Codestech1 Jun 30, 2025
736b5d0
chore: replace Key serialization with KeySerializer
Codestech1 Jun 30, 2025
1b335f2
chore: resolve TODOs
Codestech1 Jul 1, 2025
e4cee93
chore: cleanup
Codestech1 Jul 1, 2025
1ef87f0
chore: fix style of the main module
Codestech1 Jul 1, 2025
f64f2f5
chore: fix style of the test module
Codestech1 Jul 1, 2025
d82991a
fix: spotless task is failing
Codestech1 Jul 1, 2025
b6e307c
fix: lists are not serialized as arrays when it is possible (vanilla …
Codestech1 Jul 2, 2025
7a6f3b9
fix(nbt): TagStringWriter does not write compound entries in vanilla …
Codestech1 Jul 3, 2025
a87c34a
chore: replace NBTSerializerOptions#SHADOW_COLOR_MODE with NBTSeriali…
Codestech1 Jul 6, 2025
96146cc
fix: optimized lists are emitted on 25w04a and above
Codestech1 Jul 6, 2025
64d0f51
Merge branch 'KyoriPowered:main/4' into feat/nbt-text-serializer
Codestech1 Aug 11, 2025
6b5c1de
chore: replace adventure version references in the NBT Serializer fro…
Codestech1 Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove serialize/deserialize data sources TODO
  • Loading branch information
@Codestech1
Codestech1 committed Jun 22, 2025
commit 2c10acdf39ba5e1230a809f6179e5c5a0e1fd69c
2 changes: 0 additions & 2 deletions ...nbt/src/main/java/net/kyori/adventure/text/serializer/nbt/NBTComponentSerializerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ static final class Instances {
StringBinaryTag nbtEntityTag = getOptionalTag(compound, NBT_ENTITY, BinaryTagTypes.STRING);
StringBinaryTag nbtStorageTag = getOptionalTag(compound, NBT_STORAGE, BinaryTagTypes.STRING);

// TODO: Deserialize data sources
if (nbtBlockTag != null) {
return Component.blockNBT()
.nbtPath(nbtPath)
Expand Down Expand Up @@ -280,7 +279,6 @@ static final class Instances {
builder.put(SEPARATOR, this.serialize(separator));
}

// TODO: Serialize data sources
if (nbt instanceof BlockNBTComponent) {
builder.putString(NBT_BLOCK, ((BlockNBTComponent) nbt).pos().asString());
} else if (nbt instanceof EntityNBTComponent) {
Expand Down