Skip to content

1.21.5 component changes #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kezz merged 2 commits into from
Apr 24, 2025
Merged

1.21.5 component changes #1168

kezz merged 2 commits into from
Apr 24, 2025

Conversation

@Gerrygames
Copy link
Contributor

@Gerrygames Gerrygames commented Feb 28, 2025 •
edited by kezz
Loading

things that need to be looked at:

  • show_entity field renames
  • change_page is now an int (or number?)
  • order of checks when deserializing hover events

@zml2008 zml2008 added this to the 4.21.0 milestone Mar 14, 2025
@RealBauHD RealBauHD mentioned this pull request Mar 24, 2025
Merged
@kashike kashike linked an issue Mar 26, 2025 that may be closed by this pull request
Support flattened HoverEvent structure #1195
Closed
@LeeGodSRC LeeGodSRC mentioned this pull request Mar 26, 2025
Closed
6 tasks
@MiniDigger MiniDigger mentioned this pull request Mar 28, 2025
Merged
@MiniDigger
Copy link
Member

MiniDigger commented Mar 29, 2025

(rebased to fix conflicts)

@MiniDigger MiniDigger changed the title WIP: 1.21.5 component changes 1.21.5 component changes Mar 29, 2025
@MiniDigger MiniDigger marked this pull request as ready for review March 29, 2025 15:07
@MiraculixxT MiraculixxT mentioned this pull request Apr 8, 2025
Closed
@Gerrygames @MiniDigger
1.21.5 component changes
5346fc5 
Co-authored-by: MiniDigger | Martin <[email protected]>
@MiniDigger
Copy link
Member

MiniDigger commented Apr 12, 2025

rebased on adventure 4.20 and fixed the failing tests

@kezz
peek to try and determine if we're looking at a key or uuid
db8323a 
this will only break if someone has a minecraft key with a valid uuid value and they don't provide the namespace... but like, meh?
@kezz kezz added this pull request to the merge queue Apr 24, 2025
Merged via the queue into PaperMC:main/4 with commit 1178432 Apr 24, 2025
3 checks passed
@renovate renovate bot mentioned this pull request Aug 13, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiniDigger MiniDigger MiniDigger left review comments

@kezz kezz kezz approved these changes

@kashike kashike kashike approved these changes

@lucko lucko lucko approved these changes

+1 more reviewer

@turikhay turikhay turikhay left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: text-serialiser/gson area: text-serializer/json type: enhancement

Projects

None yet

Milestone

4.21.0

Development

Successfully merging this pull request may close these issues.

Support flattened HoverEvent structure

7 participants

@Gerrygames @MiniDigger @kezz @kashike @turikhay @lucko @zml2008