feature(nbt): Builders with an initial capacity #1264
Merged
+84
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezz
approved these changes
Oct 6, 2025
Member
kezz
left a comment
kezz
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just made a few minor style adjustments, but all good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds methods to create
ListBinaryTagandCompoundBinaryTagbuilders with an initial capacity.Added an
int initialCapacityfield to both builder impls that defaults to -1.When creating the backing list/map, the builders now use
initialCapacityif it isn't -1.For the builder impl constructors, I just overloaded them and added
initialCapcity, as I didn't want to specify the-1outside the impl class/change the existing ones - lmk if that's actually fine and should be changed.