feat(minimessage): add head tag #1305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improves round-trip ability with vanilla components
The update post said it defaults to false, but the actual code defaults to true. I think the code is more likely to be the actual intention.
…s-exp-1 Add PlayerHeadContents
…th no arguments as named if no sequential resolver exists
Strokkur424
force-pushed
the
feat/head-tag
branch
from
63cd529 to
475e98e
Compare
feat: migrate HeadTag claimComponent method to named arguments lol
Strokkur424
force-pushed
the
feat/head-tag
branch
from
475e98e to
7383cb1
Compare
kezz
requested changes
Sep 23, 2025
api/src/main/java/net/kyori/adventure/text/object/PlayerHeadObjectContents.java
Outdated
Show resolved
Hide resolved
kezz
approved these changes
Sep 23, 2025
Member
Author
|
Marked as draft because the named arguments branch has diverged with the unstable/4 branch and instead points to main/4. This PR requires the changes from both unstable/4 and from named arguments. Once unstable/4 is properly merged into main, this PR will be rebased and marked as mergable again. |
jpenilla
force-pushed
the
unstable/4
branch
from
db13219 to
68a0a42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #1304.