Skip to content

WIP handle distance-related names #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Machine-Maker wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP handle distance-related names #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
name variables based on distanceToSqr
  • Loading branch information
@Machine-Maker
Machine-Maker committed Jul 26, 2023
commit fb8772333916c5cd53d37e3f207c3ce5f3988532
13 changes: 13 additions & 0 deletions src/main/java/io/papermc/codebook/lvt/LvtAssignmentSuggester.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ private LvtAssignmentSuggester() {}
return suggested;
}

suggested = suggestNameFromDistanceToSqr(methodName, insn);
if (suggested != null) {
return suggested;
}

suggested = suggestNameFromStrings(methodName, insn);
return suggested;
}
Expand Down Expand Up @@ -171,6 +176,14 @@ public static String suggestNameFromRecord(final String methodName) {
return null;
}

private static @Nullable String suggestNameFromDistanceToSqr(final String methodName, final MethodInsnNode insn) {
if (!"distanceToSqr".equals(methodName) || insn.desc == null || !(insn.desc.endsWith("D") || insn.desc.endsWith("I") || insn.desc.endsWith("F"))) {
return null;
}

return "distanceSqr";
}

private static final Type stringType = Type.getType("Ljava/lang/String;");

private static @Nullable String suggestNameFromStrings(final String methodName, final MethodInsnNode insn) {
Expand Down