Skip to content

Zmq #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Zmq #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
69f9009
Added rawgovernanceobject and rawgovernancevote to ZMQ.
jhodges10 Jul 3, 2018
6471d44
Fixed missing brace
jhodges10 Jul 3, 2018
f637c7e
Fixed rawgovernancevote naming
jhodges10 Jul 3, 2018
977d707
Small tweaks, improvements to gobject and gobejct votes.
jhodges10 Jul 3, 2018
a6fad3c
Forgot semi-colon
jhodges10 Jul 3, 2018
2d0b75a
Added missing validation interface
jhodges10 Jul 4, 2018
774f207
Trying out ToJson() on objects
jhodges10 Jul 4, 2018
1724e20
Changed ToJson() to ToString()
jhodges10 Jul 4, 2018
2477ad2
Removed ToJson() on govobj
jhodges10 Jul 4, 2018
8f9d4c9
Removed ToString() entirely.
jhodges10 Jul 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Trying out ToJson() on objects
  • Loading branch information
@jhodges10
jhodges10 committed Jul 4, 2018
commit 774f2078a61d2906dd9b27bd8027a619a8d0fca6
4 changes: 2 additions & 2 deletions src/governance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ void CGovernanceManager::ProcessMessage(CNode* pfrom, const std::string& strComm
vote.Relay(connman);

// SEND NOTIFICATION TO ZMQ
GetMainSignals().NotifyGovernanceVote(vote);
GetMainSignals().NotifyGovernanceVote(vote.ToJson());
}
else {
LogPrint("gobject", "MNGOVERNANCEOBJECTVOTE -- Rejected vote, error = %s\n", exception.what());
Expand Down Expand Up @@ -366,7 +366,7 @@ void CGovernanceManager::AddGovernanceObject(CGovernanceObject& govobj, CConnman
CheckOrphanVotes(govobj, exception, connman);

// SEND NOTIFICATION TO ZMQ
Copy link
Owner Author

@PastaPastaPasta PastaPastaPasta Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tobe reverted in cleanup PR

GetMainSignals().NotifyGovernanceObject(govobj);
GetMainSignals().NotifyGovernanceObject(govobj.ToJson());


DBG( std::cout << "CGovernanceManager::AddGovernanceObject END" << std::endl; );
Expand Down
2 changes: 1 addition & 1 deletion src/zmq/zmqnotificationinterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class CZMQNotificationInterface : public CValidationInterface
// CValidationInterface
void SyncTransaction(const CTransaction& tx, const CBlockIndex *pindex, int posInBlock) override;
void UpdatedBlockTip(const CBlockIndex *pindexNew, const CBlockIndex *pindexFork, bool fInitialDownload) override;
void NotifyTransactionLock(const CTransaction &tx) override;
void NotifyTransactionLock(const CTransaction& tx) override;
Copy link
Owner Author

@PastaPastaPasta PastaPastaPasta Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo in formatting pr

void NotifyGovernanceVote(const CGovernanceVote& vote) override;
void NotifyGovernanceObject(const CGovernanceObject& object) override;

Expand Down