Fix fullDPS comparison of enabling/disabling flasks#2779
Merged
ppoelzl merged 1 commit intoPathOfBuildingCommunity:devfrom Jul 18, 2021
Merged
Fix fullDPS comparison of enabling/disabling flasks#2779ppoelzl merged 1 commit intoPathOfBuildingCommunity:devfrom
ppoelzl merged 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Member
|
This might not be related to this change specifically, since we've had tooltip discrepancies before, but when looking at this build, checking and unchecking Bottled Faith doesn't show the same changes as the tooltip: https://pastebin.com/zx9uvhuN Definitely much better than showing the entire DPS as a change, though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Verified the displayed stat comparison is correct.