Skip to content

Various gem fixes and improvements#2898

Merged
LocalIdentity merged 19 commits intoPathOfBuildingCommunity:devfrom
PJacek:gem-fixes
Jul 21, 2021
Merged

Various gem fixes and improvements#2898
LocalIdentity merged 19 commits intoPathOfBuildingCommunity:devfrom
PJacek:gem-fixes

Conversation

@PJacek
Copy link
Copy Markdown
Contributor

@PJacek PJacek commented Jul 17, 2021

I decided to gather them together instead of spamming a dozen PRs.

@PJacek PJacek added bug Something isn't working enhancement New feature, calculation, or mod labels Jul 17, 2021
Wires77
Wires77 requested changes Jul 21, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Wires77 Wires77 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. My only nitpick is that the plus looks better on the same line, instead of being on a separate line like you have it:

image

vs.

image

@Wires77 Wires77 mentioned this pull request Jul 21, 2021
Closed
@LocalIdentity LocalIdentity merged commit 87f0b12 into PathOfBuildingCommunity:dev Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wires77 Wires77 Wires77 requested changes

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees

No one assigned

Labels

bug Something isn't working enhancement New feature, calculation, or mod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PJacek @Wires77 @LocalIdentity