Merged
Conversation
added 4 commits
July 25, 2021 08:43
Defiance Banner Voltaxic Burst Rage Vortex Spectral Helix Battlemage's Cry - Partial Support
No support for global aeo buff as it doesn't work with totems atm. Need to find fix
PJacek
suggested changes
Jul 25, 2021
Contributor
PJacek
left a comment
PJacek
left a comment
There was a problem hiding this comment.
You might want to check indentation. There is a few places where you used spaces instead of tabs
* shield crush * explosive concoction * spectral helix * Fix shield crush Add overlapping wave Move alternate quality parsing to skillstatmap * Clean up Spectral Helix * Clean up Explosive Concoction * Remove tags * Remove tags Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Does not implement the attack speed based off of main skill
Also adds support for Void Sphere, Hydrosphere and Earthquake enchants
ppoelzl
reviewed
Jul 26, 2021
ppoelzl
reviewed
Jul 26, 2021
ppoelzl
requested changes
Jul 26, 2021
src/Data/Skills/act_int.lua
Outdated
| mod("MinionModifier", "LIST", { mod = mod("BleedChance", "BASE", nil, ModFlag.Attack) }) | ||
| }, | ||
| ["non_reaper_minion_damage_+%_final"] = { | ||
| mod("MinionModifier", "LIST", { mod = mod("Damage", "MORE", nil) }, 0, 0, { type = "SkillName", skillName = "Summon Reaper", neg = true }, { type = "GlobalEffect", effectType = "Buff", unscalable = true }), |
Member
There was a problem hiding this comment.
Suggested change
| mod("MinionModifier", "LIST", { mod = mod("Damage", "MORE", nil) }, 0, 0, { type = "SkillName", skillName = "Summon Reaper", neg = true }, { type = "GlobalEffect", effectType = "Buff", unscalable = true }), | |
| mod("MinionModifier", "LIST", { mod = mod("Damage", "MORE", nil) }, 0, 0, { type = "SkillName", skillName = "Summon Reaper", neg = true }, { type = "GlobalEffect", effectType = "Buff", unscalable = true }), |
| modDB:NewMod("InfernalActive", "FLAG", true) -- Prevents effect from applying multiple times | ||
| elseif activeSkill.activeEffect.grantedEffect.name == "Battlemage's Cry" and not modDB:Flag(nil, "BattlemageActive") then | ||
| local battlemageSpellToAttack = activeSkill.skillModList:Sum("BASE", env.player.mainSkill.skillCfg, "BattlemageSpellIncreaseApplyToAttackPer5MP") | ||
| local battlemageSpellToAttackMax = m_floor(150 * buff_inc) |
Member
There was a problem hiding this comment.
Consider refactoring this magic number to data.misc.
| local battlemageSpellToAttack = activeSkill.skillModList:Sum("BASE", env.player.mainSkill.skillCfg, "BattlemageSpellIncreaseApplyToAttackPer5MP") | ||
| local battlemageSpellToAttackMax = m_floor(150 * buff_inc) | ||
| local battlemageCritChance = activeSkill.skillModList:Sum("BASE", env.player.mainSkill.skillCfg, "BattlemageCritChancePer5MP") | ||
| local battlemageCritChanceMax = m_floor(30 * buff_inc) |
Member
There was a problem hiding this comment.
Consider refactoring this magic number to data.misc.
|
Thanks for all your hard work guys! Looking forward to Forbidden Rite. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Voltaxic Burst
Rage Vortex
Spectral Helix
Battlemage's Cry - Partial Support
Earthbreaker - Partial Support
Absolution
Manabond