Skip to content

Conversation

samvloeberghs
Copy link
Contributor

master...samvloeberghs:master#diff-04c6e90faac2675aa89e2176d2eec7d8L49:

When you follow the guide and you install typings globally, you don't need to reference it into node modules, right?

master...samvloeberghs:master#diff-04c6e90faac2675aa89e2176d2eec7d8L54

I just followed you guys setup description and http://0.0.0.0:3000 doesn't work by default on a Windows machine. So I've added http://localhost:3000.

Grtz

@samvloeberghs
Copy link
Contributor Author

I've just spotted the use of 0.0.0.0 in the webpack config files as well.
https://github.com/AngularClass/angular2-webpack-starter/blob/master/webpack.prod.config.js#L19
https://github.com/AngularClass/angular2-webpack-starter/blob/master/webpack.config.js#L18

Is it ok to just use localhost? On a Windows machine, the use of 0.0.0.0 is breaking functionality hard.

@PatrickJS
Copy link
Owner

0.0.0.0 was used for virtual machines but we can change it back and I'll just add it to FAQ.

README.md Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you leave this

@samvloeberghs
Copy link
Contributor Author

done but please validate
(i'll remember to rebase next time)

@PatrickJS
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants