Skip to content

Build fails on node 4.x due to old ws dependency #47

@robertknight

Description

@robertknight

The build currently fails on Node 4.x due to a dependency on an old version of bufferutil via the ws dependency.

Given that the ws library is a completely trivial wrapper when used in the browser, is this dependency really needed? As noted at websockets/ws#577 it adds a whole bunch of extras that the user will need to have in order to build angular-websocket via npm.

I'm going to submit a PR to update the ws dependency but can you see any good reasons not to just remove the dependency entirely?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions