Fix defaults sent to TT subclasses. Basically, don't send any. #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The patch itself looks good. I think we should probably drop information about those different defaults in the doc, though. |
Contributor
Author
|
Ok. Updated the doc a bit. Since the other PR was accepted, went ahead and rolled in the "don't send tags either" mod I mentioned earlier too. Probably a little easier to read, but let me know if you'd rather have it separated. |
Contributor
Author
|
Sorry. I had to rebase this one as it overlapped PR951. It's not quite so easy to read now... |
Member
|
Looks good to me, +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This is a problem I had earlier converting an existing subclassed TT app to Dancer. Dancer silently changed ANYCASE blowing the app up because it used reserved words everywhere as variables. This change nixes Dancer defaults when using TT subclass. The theory is the existing subclass already does things how it needs them done, so don't fool with it. The patch honors settings in config.yml, if they exist, but doesn't add any baggage if the user didn't explicitly say to. I've left the tags alone here since I've another PR regarding their quoting. I'll come back to it after the dust settles... or not. Your call. Thanks.