Skip to content

json Utf8 behavior #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

json Utf8 behavior #964

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eeccedf
json encoding test
yanick Sep 22, 2013
18c5517
encode/decode as binary utf8
yanick Sep 22, 2013
cb0dbc7
amend documentation for the utf8 behavior
yanick Sep 22, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
encode/decode as binary utf8 
Deals with the funny stuff seen in #771.

The documentation should also make clear what we do turn on the
utf8 flag on by default.

We should also make sure this doesn't
break other stuff at a distance -- I'm quite weary of the
comment in 'serialize' that we don't utf8 the thing there
because it's done "later on"...
  • Loading branch information
@yanick
yanick committed Sep 22, 2013
commit 18c5517b47d41fb0da64c34d6865baa22269035c
5 changes: 4 additions & 1 deletion lib/Dancer/Serializer/JSON.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ sub deserialize {
# Standard JSON behaviour is fine when serializing; we'll end up
# encoding as UTF8 later on.
sub _serialize_options_as_hashref {
return shift->_options_as_hashref(@_);
my $self = shift;
my $options = $self->_options_as_hashref(@_) || {};
$options->{utf8} = 1 if !exists $options->{utf8};
return $options;
}

# JSON should be UTF8 by default, so explicitly decode it as such
Expand Down