Disallow multiple threads using the same Context, even at different times #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linussvarm
reviewed
Aug 11, 2019
| order to save system resources if a large number of functions are created. | ||
| """ | ||
| if own_executor: | ||
| self._threadpool = concurrent.futures.ThreadPoolExecutor(max_workers=1) |
Collaborator
There was a problem hiding this comment.
This only replaces the threadpool of this instance, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, this one was a bit tricky.
It started out with an issue happening rarely. Finally I was able to reliably reproduce it get a track trace in GDB which showed a segfault in
strstr. That led to the fix in module.c.The fix in module.c only turns a segfault into a Python exception, though. The issue is reliably reproduced by the added unit tests. Different threads accessing a QuickJS runtime is a problem, even if this happens at different times (this wrapper had locks for this reason). I interpreted the QuickJS documentation differently.
The fix is to force all JS execution to happen on a designated thread, either a single one globally or one per function.