Skip to content

Conversation

@jasl
Copy link
Contributor

@jasl jasl commented Dec 5, 2022

paritytech/substrate@polkadot-v0.9.32...polkadot-v0.9.33

Please also review upstream changes, this version commits is much, I may missing something
Notable changes:

pallet-contracts supports Indeterministic has included, but it seems set AllowIndeterministic will panic by

---- runtime::tests::gas_limit_works stdout ----
thread 'runtime::tests::gas_limit_works' panicked at 'Expected Ok(_). Got Err(
    Module(
        ModuleError {
            index: 4,
            error: [
                29,
                0,
                0,
                0,
            ],
            message: Some(
                "Indeterministic",
            ),
        },
    ),
)', crates/pink/src/runtime.rs:385:9

set Deterministic which keep current behavior is fine, maybe need some refactor to enable it?

@jasl jasl force-pushed the polkadot-v0.9.33 branch from 48728fa to e161931 Compare December 5, 2022 18:56
@jasl jasl force-pushed the polkadot-v0.9.33 branch from e161931 to 4180c51 Compare December 5, 2022 19:06
@jasl
Copy link
Contributor Author

jasl commented Dec 5, 2022

Subxt made some changes that need refactor pherry too, but I don't upgrade pherry in this PR

@jasl jasl requested a review from kvinwang December 5, 2022 20:20
@jasl jasl marked this pull request as ready for review December 5, 2022 20:20
Copy link
Collaborator

@kvinwang kvinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasl jasl merged commit 760e904 into master Dec 6, 2022
@jasl jasl deleted the polkadot-v0.9.33 branch December 6, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants