Skip to content

Add contract cluster related functionalities #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shelvenzhou merged 23 commits into from
Feb 7, 2022
Merged

Add contract cluster related functionalities #620

shelvenzhou merged 23 commits into from
Feb 7, 2022

Conversation

@shelvenzhou
Copy link
Contributor

@shelvenzhou shelvenzhou commented Jan 5, 2022 •
edited
Loading

  • Support add/remove workers for contract cluster
    • will be done after the contract state is written back to the chain
  • Allow user to specify cluster to deploy contract
    • Anyone can freely deploy contracts to any cluster with no access control
  • Support deploy the contract to worker group
    • If a contract is deployed to an existing cluster, it must specify the same worker group
  • Provision contract key to contract cluster
  • Use ContractId to specify contract instead of ContractPubkey and generate it on-chain when instantiating
  • Add e2e test for code upload and contract instantiation

@shelvenzhou
Copy link
Contributor Author

shelvenzhou commented Jan 6, 2022

This PR follows the #546

shelvenzhou
shelvenzhou commented Jan 6, 2022
View reviewed changes
@shelvenzhou shelvenzhou marked this pull request as ready for review January 6, 2022 02:10
h4x3rotab
h4x3rotab reviewed Jan 17, 2022
View reviewed changes
Copy link
Contributor

@h4x3rotab h4x3rotab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the contract related features from pallet-registry to pallet-fat in a future PR?

@shelvenzhou
Copy link
Contributor Author

shelvenzhou commented Jan 25, 2022

Move the contract related features from pallet-registry to pallet-fat in a future PR?

Will do

kvinwang
kvinwang reviewed Jan 28, 2022
View reviewed changes
h4x3rotab
h4x3rotab reviewed Jan 29, 2022
View reviewed changes
h4x3rotab
h4x3rotab approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@h4x3rotab h4x3rotab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please remember to move to cluster based key dispatch later

@shelvenzhou shelvenzhou merged commit a434af3 into master Feb 7, 2022
@shelvenzhou shelvenzhou deleted the contract-improvement branch February 7, 2022 05:52
This was referenced Feb 7, 2022
Closed
Closed
@shelvenzhou shelvenzhou mentioned this pull request Mar 1, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvinwang kvinwang kvinwang left review comments

@h4x3rotab h4x3rotab h4x3rotab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shelvenzhou @h4x3rotab @kvinwang