Allow calibration dimensions in mm#2479
Open
auscompgeek wants to merge 1 commit intoPhotonVision:mainfrom
Open
Allow calibration dimensions in mm#2479auscompgeek wants to merge 1 commit intoPhotonVision:mainfrom
auscompgeek wants to merge 1 commit intoPhotonVision:mainfrom
Conversation
github-actions
Bot
added
the
frontend
8 tasks
samfreund
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a convenient way to enter calibration board marker dimensions in millimetres, instead of having to manually convert from millimetres to inches before inputting. This is particularly useful as calib.io displays dimensions in millimetres, and the provided 1" 8x8 ChArUco board PDF may end up outside a printer's printable area when printed on A4.
No backend changes -- the dimensions are converted to inches on the frontend before sending to the backend.
Screenshots
The defaults:
After switching to mm:
Meta
Merge checklist:
If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedlyIf this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends)If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updatedIf this PR addresses a bug, a regression test for it is addedIf this PR adds a dependency, the license has been checked for compatibility and steps taken to follow it