Feat: adapter v4 - #79
Merged
Merged
Conversation
JonathanAmenechi
marked this pull request as ready for review
July 10, 2025 00:58
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the “emergency resolution” workflow with a “manual resolution” flow, updating the safety period, method names, events, storage fields, and all tests accordingly. It also introduces a new deployment script and removes the old one.
- Rename emergency flags and resolution functions/events to manual equivalents with a new SAFETY_PERIOD constant
- Update interface, implementation, tests, and gas snapshot to reflect manual resolution
- Add
DeployAdapter.s.sol, removeDeploy.s.sol, and updatedeploy_adapter.sh
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/UmaCtfAdapter.sol | Renamed EMERGENCY_SAFETY_PERIOD, emergencyResolve, flags, storage fields, and events to manual equivalents; updated safety period to 1 hour |
| src/interfaces/IUmaCtfAdapter.sol | Updated storage field and event names/docs for manual resolution |
| src/test/UmaCtfAdapter.t.sol | Renamed all test functions and expectations from emergency to manual resolution |
| src/deploy/DeployAdapter.s.sol | Added new deployment script using deployAdapter |
| src/deploy/Deploy.s.sol | Removed old Deploy script |
| deploy/scripts/deploy_adapter.sh | Updated Forge invocation to DeployAdapter and added admin arg |
| .gas-snapshot | Regenerated snapshot to include manual-resolution test costs |
Comments suppressed due to low confidence (1)
src/test/UmaCtfAdapter.t.sol:1071
- [nitpick] Test function name has an extra 'd'. Rename to
testPriceDisputedResolveManuallyfor consistency.
function testPriceDisputedResolveManuallyd() public {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Description
Testing instructions
Types of changes
Notes
Status
WIPif necessary (changes not yet made).