Skip to content

Move to CodeAction #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 18, 2020
Merged

Move to CodeAction #1193

merged 7 commits into from
Feb 18, 2020

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Feb 13, 2020 •
edited
Loading

Fixes #1191

This allows us to show up here:

image

cc @mjbvz

@TylerLeonhardt
Copy link
Member Author

TylerLeonhardt commented Feb 13, 2020 •
edited
Loading

This is pending the following Omnisharp bug fix: OmniSharp/csharp-language-server-protocol#211 (the code works but the test always fails because of that bug)

This is fixed now.

@TylerLeonhardt
Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1

See the complete overview on Codacy

This was referenced Feb 18, 2020
Closed
Closed
Closed
@TylerLeonhardt TylerLeonhardt merged commit 3fcd0c6 into PowerShell:master Feb 18, 2020
@TylerLeonhardt TylerLeonhardt deleted the move-to-codeaction branch February 18, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch all CodeActions from Command to CodeAction

2 participants

@TylerLeonhardt @rjmholt