Skip to content

Conversation

fflaten
Copy link
Contributor

@fflaten fflaten commented Aug 15, 2022

PR Summary

Trims leading whitespace in Pester symbol name. Also implements scaffolded regression test.

PR Context

Fix #1891

@fflaten fflaten requested a review from a team August 15, 2022 17:57
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you so much!

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Pester labels Aug 15, 2022
@andyleejordan andyleejordan enabled auto-merge (squash) August 15, 2022 18:28
@fflaten
Copy link
Contributor Author

fflaten commented Aug 15, 2022

That CanUnregisterCommand test really hates PS5.1 😞

@andyleejordan
Copy link
Member

It really does 😭 these tests are a lot more stable than were...but yeah the 5.1 is still hella flaky.

@andyleejordan andyleejordan merged commit b0bfce7 into PowerShell:main Aug 15, 2022
@fflaten fflaten deleted the pester-symbolname branch August 15, 2022 19:45
@andyleejordan andyleejordan mentioned this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Pester Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Pester symbols have leading whitespace in search
2 participants