Fix IsExternalInit bug, re-enable tests, and update OmniSharp to v0.19.7
#1953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expect these tests to fail as they originally did until this PR can include a v0.19.7 update of OmniSharp 😢 |
This reverts commit e1817de.
andyleejordan
force-pushed
the
andschwa/workaround-omnisharp
branch
from
20a92fd to
fc982eb
Compare
|
Yay! David got v0.19.7 out and now we can merge this! |
andyleejordan
changed the title
IsExternalInit bug and re-enable testsIsExternalInit bug, re-enable tests, and update OmniSharp to v0.19.7
To build against project at `../csharp-language-server-protocol`.
We were also missing the conditional type forward.
andyleejordan
force-pushed
the
andschwa/workaround-omnisharp
branch
from
fc982eb to
4ddb93f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables the tests that were disabled in #1946. They pass against a local build of O# with this PR: OmniSharp/csharp-language-server-protocol#895.