Skip to content

Ignore didOpen notifications for git schemed documents from VS Code #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Ignore didOpen notifications for git schemed documents from VS Code #2090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/PowerShellEditorServices/Services/TextDocument/Handlers/TextDocumentHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,14 @@ protected override TextDocumentSyncRegistrationOptions CreateRegistrationOptions

public override Task<Unit> Handle(DidOpenTextDocumentParams notification, CancellationToken token)
{
// We're receiving notifications for special "git" scheme files from VS Code, and we
// need to ignore those! Otherwise they're added to our workspace service's opened files
// and cause duplicate references.
if (notification.TextDocument.Uri.Scheme == "git")
{
return Unit.Task;
}

// We use a fake Uri because we only want to test the LanguageId here and not if the
// file ends in ps*1.
TextDocumentAttributes attributes = new(s_fakeUri, notification.TextDocument.LanguageId);
Expand Down