Skip to content

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Aug 26, 2021

This extends the extension's test matrix to match that of PowerShellEditorServices itself and documents our best-effort nature of supporting various platforms. It also updates our readme and the copy of it supplied to Azure Data Studio. Resolves #3529.

@andyleejordan andyleejordan requested a review from rjmholt August 26, 2021 18:39
@andyleejordan andyleejordan force-pushed the andschwa/platforms branch 3 times, most recently from b33a8da to ee65706 Compare August 26, 2021 19:36
@andyleejordan andyleejordan marked this pull request as ready for review August 26, 2021 19:39
@andyleejordan andyleejordan changed the title Extend CI test matrix to match PowerShellEditorServices Extend CI test matrix and update readme(s) Aug 26, 2021
@ghost ghost added the Issue-Enhancement A feature request (enhancement). label Aug 26, 2021
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great updates


### Emeriti

- [Keith Hill](https://github.com/rkeithhill) - [@r_keith_hill](http://twitter.com/r_keith_hill)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also add SeeminglyScience here

@andyleejordan andyleejordan merged commit cdd7d78 into master Aug 26, 2021
@andyleejordan andyleejordan deleted the andschwa/platforms branch August 26, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Test Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ADS readme
2 participants