Skip to content

Use status bar colors from theme instead of hardcoded values #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2021
Merged

Use status bar colors from theme instead of hardcoded values #3531

merged 1 commit into from
Aug 27, 2021

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Aug 26, 2021 •
edited
Loading

Resolves #2436 and #1779.

@ghost ghost added Area-UI Issue-Enhancement A feature request (enhancement). labels Aug 26, 2021
@andyleejordan andyleejordan linked an issue Aug 26, 2021 that may be closed by this pull request
Add the ability to customize Session Status color #1779
Closed
@andyleejordan
Copy link
Member Author

@Tyriar is this the way you would recommend to do it?

@andyleejordan andyleejordan requested a review from rjmholt August 26, 2021 22:58
@andyleejordan andyleejordan marked this pull request as ready for review August 26, 2021 22:58
@andyleejordan
Copy link
Member Author

Also @TylerLeonhardt I've hardly touched the frontend so far, how's this? 😅 Everything's been in the backend.

TylerLeonhardt
TylerLeonhardt approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

Tyriar
Tyriar approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tyriar is this the way you would recommend to do it?

Pretty much yeah, I just adopted it in my extension and setting .color and .backgroundColor like this is what I did 👍

@andyleejordan andyleejordan force-pushed the andschwa/statusbarcolors branch from 8bc2695 to 099cb2b Compare August 27, 2021 17:17
@andyleejordan andyleejordan enabled auto-merge (squash) August 27, 2021 17:18
@andyleejordan andyleejordan linked an issue Aug 27, 2021 that may be closed by this pull request
Powershell icon is unreadable on light themes #3409
Closed
@andyleejordan andyleejordan merged commit 4d4911a into master Aug 27, 2021
@andyleejordan andyleejordan deleted the andschwa/statusbarcolors branch August 27, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@Tyriar Tyriar Tyriar approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
4 participants
@andyleejordan @Tyriar @TylerLeonhardt @rjmholt