Tests: Fixed polynomial backtracking test #2891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, parsing a regex required the regex the be a valid ES5 regex. This used to be fine as only language definition regexes were parsed but this changed recently with #2688. Now, all regexes and regex usages are tested. This makes everything safe but introduced a new problem.
When using
"str".split(/regex/), the JS engine will create a temporary new regex with theyflag added. Obviously, theyflag isn't valid in ES5, so our backtracking tests fail for seemingly no reason.The fix is simple: allow regexes of later JS versions.
I will immediately merge this because this blocks #2885.