Skip to content

Fix crash issue when trying to parse bad skin JSON #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheSharkyOfficial wants to merge 16 commits into
base: master
Choose a base branch
from
+7 −1
Open

Fix crash issue when trying to parse bad skin JSON #3712

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d40199e
Fix crash issue when trying to parse bad skin JSON
TheSharkyOfficial Aug 2, 2025
e0de7e6
fixing indent to pass standardjs test
TheSharkyOfficial Aug 2, 2025
af5488e
added test
TheSharkyOfficial Aug 3, 2025
e967048
changed double quotes into single quotes
TheSharkyOfficial Aug 3, 2025
e3ca4ce
Merge branch 'PrismarineJS:master' into patch-3
TheSharkyOfficial Aug 4, 2025
ad5be44
replaced custom parsing with mojangson
TheSharkyOfficial Aug 4, 2025
8d5707b
linting
TheSharkyOfficial Oct 26, 2025
e68f460
fix
TheSharkyOfficial Oct 26, 2025
245e829
lint
TheSharkyOfficial Oct 26, 2025
99419a6
Merge branch 'PrismarineJS:master' into patch-3
TheSharkyOfficial Oct 26, 2025
002ce58
linting
TheSharkyOfficial Oct 26, 2025
8e65d86
linting
TheSharkyOfficial Oct 26, 2025
3fbf2ef
test
TheSharkyOfficial Oct 26, 2025
07f80a7
deleted non-working AI generated test
TheSharkyOfficial Oct 26, 2025
ba20937
linting
TheSharkyOfficial Oct 26, 2025
25cd247
tested and fixed
TheSharkyOfficial Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing indent to pass standardjs test
  • Loading branch information
@TheSharkyOfficial
TheSharkyOfficial authored Aug 2, 2025
commit e0de7e68728d78f8e9f0d22310e95fff2ae390ea
6 changes: 3 additions & 3 deletions lib/plugins/entities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,9 +944,9 @@ function extractSkinInformation (properties) {
}

const skinTextureString = Buffer.from(props.textures.value, 'base64').toString('utf8')
.split("{textures:").join("{\"textures\":")
.split("{SKIN:").join("{\"SKIN\":")
.split("{url:").join("{\"url\":")
.split("{textures:").join("{\"textures\":")
.split("{SKIN:").join("{\"SKIN\":")
.split("{url:").join("{\"url\":")

const skinTexture = JSON.parse(skinTextureString)

Expand Down
Loading