Disable physics during configuration packet #3722
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Tests fail I think we should rather disable a lot more than specifically physics during configuration phases And it would be best to add a test for this (probably an internal test), so it will keep working |
Those seem like flaky tests to me. They don't have anything to do with this pr |
|
Could this be merged? |
|
No please see my previous message on what still needs to be done here |
The tests that failed did not seem related at all to the PR, as Omena0 said above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that connecting to a server with minecraft version
1.20.4didn't work - throwing quite ambiguous errorAn internal error occurred in your connection, but after trying different things for a while I figured it works well on1.20and only some servers throw that error. I compared the packet trace between those two versions and one difference I found was that in 1.20.4, servers sendstart_configurationpackets during gameplay to reconfigure clients, but mineflayer's physics plugin was missing handlers for this. The bot continued sending position packets while in configuration state, which is invalid and causes the server to kick the client