Skip to content

Conversation

raviautar
Copy link
Member

Parses specifications of a certain specimen and stores into hash map.

* Created by ravishivam on 4-5-16.
*/
public interface Data {
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An interface without methods is usually not what you want. Ideally every method of the implementations of an interface should override the interface methods. Also, Data is not a clear name.

@smesseim
Copy link
Member

smesseim commented May 6, 2016

Is Specimen a replacement for Segment? What exactly is the purpose of Specimen?

@raviautar
Copy link
Member Author

Specimen is NOT a replacement for segment. A specimen is whom a certain genome belongs to. The genome is contructed by a serie of segments. Thus segments are pieces of a genome that belongs to a certain specimen. The specimen class tells something about the person that the genome belongs to i.e. age, gender, HIV status etc.

@smesseim
Copy link
Member

smesseim commented May 7, 2016

Is Subject already linked to the Nodes?

@raviautar
Copy link
Member Author

Yes. It is. Because Segment now contains a List with specimen (genomes) it belongs to. And that can directly be linked to a certain specimen. The name of the specimen (format: TKxxxx) is the key with which you can access all the information of that specimen in the SpecimenMap class

@smesseim
Copy link
Member

smesseim commented May 7, 2016

LGTM

1 similar comment
@SamuelSital
Copy link
Member

LGTM

@raviautar raviautar merged commit ec1b64c into develop May 7, 2016
@raviautar raviautar deleted the feature/metadataparser branch May 7, 2016 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants