-
Notifications
You must be signed in to change notification settings - Fork 1
Parser for the metadata. #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge branch 'feature/phyloparser' into feature/linkmetadata
* Created by ravishivam on 4-5-16. | ||
*/ | ||
public interface Data { | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An interface without methods is usually not what you want. Ideally every method of the implementations of an interface should override the interface methods. Also, Data
is not a clear name.
Is |
Specimen is NOT a replacement for segment. A specimen is whom a certain genome belongs to. The genome is contructed by a serie of segments. Thus segments are pieces of a genome that belongs to a certain specimen. The specimen class tells something about the person that the genome belongs to i.e. age, gender, HIV status etc. |
Is |
Yes. It is. Because Segment now contains a List with specimen (genomes) it belongs to. And that can directly be linked to a certain specimen. The name of the specimen (format: TKxxxx) is the key with which you can access all the information of that specimen in the SpecimenMap class |
LGTM |
1 similar comment
LGTM |
Parses specifications of a certain specimen and stores into hash map.