Fixes for wave kinematics #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav-og
added a commit
that referenced
this pull request
Dec 12, 2025
PR #77 was made before a major refactor - I've ported the changes over into the relevant new locations.
dav-og
added a commit
that referenced
this pull request
Dec 12, 2025
* Port Wheeler stretching fixes from PR #77 (by tridelat) PR #77 was made before a major refactor - I've ported the changes over into the relevant new locations. * Improve robustness in wave kinematics utilities - Treat non-positive/very large/infinite water depth as “effectively infinite” in is_in_deep_water() (consistent with ComputeWaveNumber()), and clarify the 89.4 kh threshold is a numerical switch (tanh(kh)≈1). - Avoid Wheeler stretching when depth is non-physical/unbounded (≤0, inf, or very large), and guard against h + eta near zero to prevent division-by-zero. - Add checks and small‑kh limiting forms in water velocity/acceleration to avoid sinh(kh) division‑by‑zero / NaNs as k -> 0.
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the following issues: