[Fix] Use original transaction ordering in speculation#2421
Merged
howardwu merged 2 commits intomainnet-stagingfrom Apr 5, 2024
Merged
[Fix] Use original transaction ordering in speculation#2421howardwu merged 2 commits intomainnet-stagingfrom
howardwu merged 2 commits intomainnet-stagingfrom
Conversation
howardwu
approved these changes
Apr 5, 2024
howardwu
changed the title
This was referenced Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR updates
prepare_for_speculateto output a sorted version of the valid and aborted transactions based on the order of the original transaction list. Previously, we were outputting the transactions based on our verification ordering.Test Plan
A test was added to ensure that the order of transactions is preserved correctly.