Fix multiprocessing hang on FSErrors #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
reviewed
Jul 13, 2018
fs/errors.py
Outdated
|
|
||
| def __init__(self, namespace): | ||
| # type: (Text) -> None | ||
| self.namespace=namespace |
There was a problem hiding this comment.
Tiny pep8 thing, should be whitespace around =
|
@Spacerat Looks good, thanks. Just a tiny request in the comments, and its good to merge. |
|
👍 thanks for the review @willmcgugan . I've fixed the formatting error now |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the problem of subclasses of FSError/Exception causing multiprocessing to hang ( issue #183 ) if they change the arguments to
__init__. I went with @willmcgugan 's suggestion to implement__reduce__in each subclass wherever it was required.