Update movedir methods of WrapFS to use the delegate FS method
#511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
The current implementation of
WrapFS.moveandWrapFS.movedirwas always going through thefs.movefunctions. Formove, this was just causing one extra call (WrapFS.move -> fs.move.move_file -> WrapFS.delegate_fs().move). But formovedir, this was never the case (fs.move.move_diris always copying/removing the files, and never tries to callmovedirbecause of recursivity issues, this should be fixed too at some point):