skip tests using thread-unsafe constructs on free-threaded build #4476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
Test failures in the merge queue are because of #4447 I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips tests that rely on setting
sys.unraisablehookand tests that usewarnings.catch_warnings.Setting anything on the
sysmodule is overriding global state, so it fundamentally isn't thread safe. An alternative would be to make it so any test that usesUnraisableCaptureneeds to acquire a mutex first. Happy to do that if anyone is uncomfortable with skipping tests.Unfortunately there isn't a similar workaround for tests relying on
catch_warnings, it's fundamentally not thread safe, as mentioned in the docs for it.