Avoid interpolating values into bash #4774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can lead to code execution. See https://woodruffw.github.io/zizmor/audits/#template-injection for details
sethmlarson
approved these changes
Dec 6, 2024
Icxolu
reviewed
Dec 7, 2024
| env: | ||
| # Don't put these in bash, because we don't want the expansion to | ||
| # risk code execution | ||
| BASE_REF: "refs/heads/{{ github.event.pull_request.base.ref }}" |
Contributor
There was a problem hiding this comment.
Suggested change
| BASE_REF: "refs/heads/{{ github.event.pull_request.base.ref }}" | |
| BASE_REF: "refs/heads/${{ github.event.pull_request.base.ref }}" |
I think this one is missing a "$" for expansion? At least it is currently broken in #4768
davidhewitt
pushed a commit
that referenced
this pull request
Jan 3, 2025
This can lead to code execution. See https://woodruffw.github.io/zizmor/audits/#template-injection for details
davidhewitt
pushed a commit
that referenced
this pull request
Jan 11, 2025
This can lead to code execution. See https://woodruffw.github.io/zizmor/audits/#template-injection for details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can lead to code execution. See https://woodruffw.github.io/zizmor/audits/#template-injection for details