rename Python::allow_threads to Python::detach
#5221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
reviewed
Jul 4, 2025
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, looks good to me with one tiny suggestion
Co-authored-by: David Hewitt <[email protected]>
ngoldbaum
reviewed
Jul 4, 2025
Contributor
There was a problem hiding this comment.
I can't comment in-context, but the text starting at line 120 through line 140 or so probably needs a revision pass, since you're fixing the API naming issues that the text is apologizing for. I still think the thrust of that text is important - it's a very common misconception that you don't need to explicitly attach or detach on the free-threaded build.
Contributor
Author
There was a problem hiding this comment.
Yes, that's part of the general docs pass, that I've prepared as a follow up so that we have smaller diff for easier reviewing.
Contributor
There was a problem hiding this comment.
Good, thanks for already taking care of that :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup #5209
Closes #3987
I've prepared a general docs pass as a followup.