Skip to content

Conversation

@OverLordGoldDragon
Copy link
Contributor

I saw linear scales in some important code recently (written by those who don't know better).

There will almost never be a use case for this. CWT is a log transform and should be tiled logarithmically.

If my example of an exponential chirp is unsatisfying, feel free to revert, but it's what illustrates the flaw of the current approach; the signal should trace out a straight line in CWT.

@rgommers rgommers added this to the v1.9.0 milestone Jul 29, 2025
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OverLordGoldDragon, this looks like a useful change to make. In the rest of the narrative docs for cwt (https://pywavelets.readthedocs.io/en/latest/ref/cwt.html) it's emphasized multiple times that it should be log scale, so making it consistent also in the docstring examples makes sense.

@rgommers rgommers merged commit 7f4f74a into PyWavelets:main Aug 3, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants