Skip to content

Conversation

shermanjasonaf
Copy link
Contributor

@shermanjasonaf shermanjasonaf commented Sep 23, 2025

Summary/Motivation:

This PR modifies the PyROS solver output logging system so that the output shown by the default logger (or any other INFO-level logger) is simplified.

Changes proposed in this PR:

  • Log the following at DEBUG, rather than INFO level: (i) full PyROS solver config, (ii) backup solver invocations, (iii) subproblem solve failures for the master feasibility and DR polishing problems, (iv) timing profile, (v) component statistics for the preprocessed model
  • Add indication of backup solver invocation to the (INFO-level) iteration log table
  • Log component statistics for the un-preprocessed model at INFO level
  • Update tests and documentation according to the new changes

TODO

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@shermanjasonaf
Copy link
Contributor Author

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 96.63866% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.33%. Comparing base (e8ed5dd) to head (cca2ef7).

Files with missing lines Patch % Lines
pyomo/contrib/pyros/separation_problem_methods.py 88.88% 2 Missing ⚠️
pyomo/contrib/pyros/master_problem_methods.py 66.66% 1 Missing ⚠️
pyomo/contrib/pyros/pyros.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3732      +/-   ##
==========================================
+ Coverage   89.31%   89.33%   +0.02%     
==========================================
  Files         896      896              
  Lines      103697   103774      +77     
==========================================
+ Hits        92619    92709      +90     
+ Misses      11078    11065      -13     
Flag Coverage Δ
builders 29.09% <13.44%> (+<0.01%) ⬆️
default 85.94% <95.79%> (?)
expensive 35.85% <13.44%> (?)
linux 86.98% <96.63%> (-2.07%) ⬇️
linux_other 86.98% <96.63%> (+0.02%) ⬆️
osx 83.11% <95.79%> (+0.01%) ⬆️
win 85.23% <96.63%> (+<0.01%) ⬆️
win_other 85.23% <96.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants