Skip to content

Fix footnote ordering #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waylan merged 17 commits into from
Aug 1, 2025
Merged

Fix footnote ordering #1546

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d7203c9
Fix footnote ordering so footnotes are listed in the order in which t…
aeskildsen Jul 21, 2025
1d13ae4
Minor fixes for work on footnotes extension
aeskildsen Jul 22, 2025
a6d1e0f
Add comprehensive tests for footnotes extension
aeskildsen Jul 22, 2025
9547ade
Merge remote-tracking branch 'upstream/master' into footnotes-order
aeskildsen Jul 22, 2025
0c2e4bf
Rework new tests for footnote extension
aeskildsen Jul 24, 2025
ce45459
Add tricky edge case that messes with the reordering introduced in d7…
aeskildsen Jul 27, 2025
5d7f8ca
Refactor reordering to depend on inline processing
aeskildsen Jul 29, 2025
1c160ef
Ensure inlinepatterns iterate through elements in document order
waylan Jul 30, 2025
62b12b7
Add loose list test
waylan Jul 30, 2025
5e437a0
lint cleanup
waylan Jul 30, 2025
da1e20d
fix my cleanup
waylan Jul 30, 2025
bc3f493
cleanup comment
waylan Jul 30, 2025
d8ecae6
Add the requested changes:
aeskildsen Jul 30, 2025
ed7ff42
Add config option to support previous behavior
aeskildsen Aug 1, 2025
345f52e
Update docs to clarify terminology
aeskildsen Aug 1, 2025
a0755e8
Add 'word' as an example of a footnote name/id
aeskildsen Aug 1, 2025
dbd7068
fix spelling
waylan Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup comment
  • Loading branch information
@waylan
waylan committed Jul 30, 2025
commit bc3f49325da55ae4bdfcfb671bc3c061edee413a
2 changes: 1 addition & 1 deletion tests/test_syntax/extensions/test_footnotes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ def test_footnote_reference_within_list(self):
)

def test_footnote_references_within_loose_list(self):
"""Test footnote reference within a list item."""
"""Test footnote references within loose list items."""

self.assertMarkdownRenders(
self.dedent(
Expand Down