Fix find footnote placeholder to recurse #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tigge, thanks for your contribution. Before I accept it, could you provide a test which fails before this change is applied and passes after? I'm not sure I see what this is accounting for. |
|
@waylan Test added! |
waylan
added a commit
that referenced
this pull request
Aug 29, 2015
Fix find footnote placeholder to recurse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The footnotes extension actually didn't recurse correctly when looking for the place marker. If it wasn't a child of the root element it would traverse and find the place marker but still return None in the
finderfunction.