-
Notifications
You must be signed in to change notification settings - Fork 434
Add chinese version of readme #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@MintForever please help review this! |
|
@qiyanjun Thanks for the reply~ |
|
@Opdoop can you help me also remove those HTML inline styles from the recipe table in the main Readme.md? BTW: please rebase! I did some other changes after your PR! https://textattack.readthedocs.io/en/latest/1start/support.html#start-contributing-pull-requests |
|
Sorry, I'm a newbie at git. I'm not sure how to rebase after a PR. 😅 |
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
As https://github.com/github/markup first step (2) describe Github html will be sanitized and all inline-style will be removed. So this inline style in readme is useless. Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
As https://github.com/github/markup first step (2) describe Github html will be sanitized and all inline-style will be removed. So this inline style in readme is useless. Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
Signed-off-by: Opdoop <[email protected]>
|
@qiyanjun Aloha~ I think I did it. |
|
@MintForever Hi, I noticed the |
Signed-off-by: Opdoop <[email protected]>
|
🧐Question: Where should the entry of chinese version readme be placed? |
|
@Opdoop have you solved @MintForever 's concern? @Opdoop I will add a link in the main READMe.md |
|
@qiyanjun Hi, I did get it. @MintForever his review commits are on branch |
|
@Opdoop please merge @MintForever (her) change into the PR |
|
@qiyanjun Aha~ Done~ Merged @MintForever (her) change into the PR 😃 |
|
@Opdoop thanks. Last request of change: I have revised the ordering under the "Design" section. Can you revise your Chinese version accordingly? Many thanks, |
Signed-off-by: Opdoop <[email protected]>
|
@qiyanjun Changed the order under the design section and added the Benchmarking section. |
|
I only modified |
|
The PyTest failing checks at install dependencies and the log is below: Still have no idea why this happened. |
|
@Opdoop Thanks. |
|
@qiyanjun Thank you for your valuable comments and suggestions. |
Thanks for releasing the powerful TextAttack🎉
For chinese fellows easier to get started with TextAttack, I translate the reademe to chinese. I try my best to adheres to
信、达、雅, the translation principles. But only the content is guaranteed to be informative. This chinese version may need some major review. Despite all this, it's still a good startpoint.Look forward to receiving your reply~