Polish dependencies and support python3.11 #780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi, working on this project I noticed that some of the mandatory dependencies in
requirements.txtare listed but are either not used or transitive dependencies. Moreover, some of them (pysocksandclick) force old versions to be installed, without a clear reason.Similarly, optional dependencies list
tensorflowpackages installation forcing an old version (~2 years old). This prevents new python versions to run this library. So, I propose to upgrade the version of tensorflow packages to be able to also support python 3.11 and 3.12After my changes, I ran tests on ubuntu with python3.11 and they were all passing.
As a side note, please remember to update conf.py and release the new pypi package.
Changes
tensorflowas optional dependencies insetup.pysetup.pyDeletions
requirements.txt