[CORE] Optimize the code to make MongoManager more consistent with the design #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The current implement of
MongoManagersome violations of programming.The trait
DataSourceManagerdefine a template functionlistTablesshow below:The design require the specific data source to implement
listTables(db: String), but MongoManager overwrite the template function show below:It will causes some bug. I think should to improve the implement to make
MongoManagermore consistent with the design.How was this patch tested?
No UT.