Fix:Add k8s namespace page flipping function in the background#178
Merged
Conversation
wilhelmguo
reviewed
Dec 25, 2018
| list(cluster: string): Observable<any> { | ||
| // for list all in one page | ||
| let params = new HttpParams(); | ||
| params = params.set('pageSize', 102410241024 + ''); |
Collaborator
Author
There was a problem hiding this comment.
这个地方是要做不分页的，但是接口里面没有 pageSize 就会默认指定为 10，因此这个地方指定了一个“足够大”的 pageSize，实现不是很优雅。如果改变这个问题，可以通过修改 参数解析来实现，比如，pageSize 指定为 -1 的时候，则代表 pageSize 为无限大
Collaborator
There was a problem hiding this comment.
为什么要做不分页？不是统一按照后台分页的模式了么?
Collaborator
There was a problem hiding this comment.
这个其实是getNames功能，名称可以统一改成getName 不用传分页参数
…e into fix/admin_k8s_namespace
wilhelmguo
approved these changes
Dec 28, 2018
wilhelmguo
approved these changes
Dec 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add k8s namespace page flipping function in the background