Skip to content

Fix load apikeys error when not set APIKey#33

Merged
chengyumeng merged 4 commits into
Qihoo360:masterfrom
wilhelmguo:master
Nov 21, 2018
Merged

Fix load apikeys error when not set APIKey#33
chengyumeng merged 4 commits into
Qihoo360:masterfrom
wilhelmguo:master

Conversation

@wilhelmguo
Copy link
Copy Markdown
Collaborator

No description provided.

@wilhelmguo wilhelmguo added kind/bug Categorizes issue or PR as related to a bug. sig/backend Categorizes an issue or PR as relevant to sig-backend. sig/frontend Categorizes an issue or PR as relevant to sig-frontend. labels Nov 20, 2018
@wilhelmguo
Copy link
Copy Markdown
Collaborator Author

@chengyumeng EnableApiKeys default set true

@wilhelmguo
Copy link
Copy Markdown
Collaborator Author

wilhelmguo commented Nov 21, 2018

#9

@chengyumeng chengyumeng merged commit 9684c62 into Qihoo360:master Nov 21, 2018
Copy link
Copy Markdown
Collaborator

@BennieMeng BennieMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other well

routerLink="/portal/namespace/{{cacheService.currentNamespace?.id}}/apikey"
routerLinkActive="active"
*ngIf="authService.currentNamespacePermission.apiKey.read || authService.currentUser.admin">
*ngIf="this.authService.config['enableApiKeys'] && (authService.currentNamespacePermission.apiKey.read || authService.currentUser.admin)">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要加this

@wilhelmguo wilhelmguo changed the title if load enable apikeys by config Fix load apikeys error when not set APIKey Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. sig/backend Categorizes an issue or PR as relevant to sig-backend. sig/frontend Categorizes an issue or PR as relevant to sig-frontend.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants