Skip to content

feat: add Storybook starter #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

feat: add Storybook starter #2381

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fec8004
Add Storybook starter
DustinJSilk Dec 6, 2022
e53e6e0
Update Storybook docs with preview command
DustinJSilk Dec 6, 2022
edf8ec6
Copy the project vite plugins
DustinJSilk Dec 6, 2022
7e3ba9f
Use storybook v7 and html-vite
DustinJSilk Dec 15, 2022
4a204ba
Fix tsconfig options
DustinJSilk Dec 15, 2022
db79b81
Fix storybook.build
DustinJSilk Dec 15, 2022
7aab865
Add required react dependency
DustinJSilk Dec 15, 2022
2b8caf6
fix to working storybook version and remove QWIK_LOADER eval
DustinJSilk Dec 16, 2022
feba151
Update integration to include 3rd party library
DustinJSilk Jan 16, 2023
75a130c
Include tips on using storybook with tailwind
DustinJSilk Jan 16, 2023
433ab1f
Add documentation for running with i18n
DustinJSilk Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Copy the project vite plugins
  • Loading branch information
@DustinJSilk
DustinJSilk committed Jan 16, 2023
commit edf8ec63ccf4ea3496c5a3821a09356a772c50b7
16 changes: 8 additions & 8 deletions starters/features/storybook/.storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { qwikCity } from '@builder.io/qwik-city/vite';
import { qwikVite } from '@builder.io/qwik/optimizer';
import type { StorybookViteConfig } from '@storybook/builder-vite';
import { mergeConfig } from 'vite';
import tsconfigPaths from 'vite-tsconfig-paths';
import { mergeConfig, UserConfig } from 'vite';
import baseConfig from '../vite.config';

const config: StorybookViteConfig = {
addons: ['@storybook/addon-essentials'],
Expand All @@ -14,8 +12,8 @@ const config: StorybookViteConfig = {
features: {
storyStoreV7: true,
},
viteFinal: async (config) => {
const overridenConfig = mergeConfig(config, {
viteFinal: async (defaultConfig) => {
const config = mergeConfig(defaultConfig, {
build: {
target: 'es2020',
rollupOptions: {
Expand All @@ -24,9 +22,11 @@ const config: StorybookViteConfig = {
},
});

overridenConfig.plugins = [qwikCity(), qwikVite(), tsconfigPaths(), ...overridenConfig.plugins];
const projectConfig = (baseConfig as () => UserConfig)();

return overridenConfig;
config.plugins = [...(projectConfig.plugins ?? []), ...(defaultConfig.plugins ?? [])];

return config;
},
};

Expand Down
7 changes: 1 addition & 6 deletions starters/features/storybook/.storybook/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,7 @@
"emitDecoratorMetadata": true,
"composite": true
},
"exclude": [
"../**/*.spec.ts",
"../**/*.test.ts",
"../**/*.spec.tsx",
"../**/*.test.tsx"
],
"exclude": ["../**/*.spec.ts", "../**/*.test.ts", "../**/*.spec.tsx", "../**/*.test.tsx"],
"include": [
"../src/**/*.stories.ts",
"../src/**/*.stories.tsx",
Expand Down