Skip to content

fix(core): qresume event + jsx types fixes #8134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 7, 2025
Merged

fix(core): qresume event + jsx types fixes #8134

merged 6 commits into from
Nov 7, 2025
+284 −310

Conversation

@wmertens
Copy link
Member

@wmertens wmertens commented Nov 7, 2025 •
edited
Loading

  • adds 'qresume' event back and fixes non-resuming qrl handlers
  • make the JSX even handlers only autocomplete to their correct scope

fixes #8083

@wmertens wmertens requested review from a team as code owners November 7, 2025 13:24
@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: ab5c685

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wmertens wmertens changed the base branch from main to build/v2 November 7, 2025 13:25
@wmertens wmertens force-pushed the v2-types branch 2 times, most recently from 426a495 to afb3531 Compare November 7, 2025 13:54
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 7, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8134

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8134

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8134

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8134

commit: fec79c7

Varixo
Varixo approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@Varixo Varixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens enabled auto-merge November 7, 2025 15:23
@wmertens wmertens merged commit 89a07ff into build/v2 Nov 7, 2025
18 checks passed
@wmertens wmertens deleted the v2-types branch November 7, 2025 15:29
@github-actions github-actions bot mentioned this pull request Nov 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Varixo Varixo Varixo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wmertens @Varixo