Skip to content

Conversation

@muxuezi
Copy link
Contributor

@muxuezi muxuezi commented Sep 6, 2015

  1. js file name error, there are "?..." post fix in src URL, it may be better if delete the "?..." post fix when we store js file. I use 'spilt('?')[0]' to get the js file name.
    2.Two indentation need the last line of 1-getPageMedia.py, because of scraping all file at src URL.
  2. I use os.makedirs() to avoid the error raised when '../file/' documentary was not exit initially.
  3. newline='' should use when I create csv file on Windows, otherwise there will be an additional new line under every row at csv file.

@muxuezi muxuezi changed the title A few bug on Windows CSV newline bug on Windows, but is OK on Archlinux and Mac Sep 6, 2015
@muxuezi muxuezi closed this Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants